fix: tar.bz2 archives not read to end resulting in wrong hash#1557
Merged
wolfv merged 2 commits intoconda:mainfrom Jul 28, 2025
Merged
fix: tar.bz2 archives not read to end resulting in wrong hash#1557wolfv merged 2 commits intoconda:mainfrom
wolfv merged 2 commits intoconda:mainfrom
Conversation
This was referenced Jul 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to fix reading small tar.bz2 archives to the end. The
openmparchive is only ~8kB and it looks like we are not reading the last ~4 or so bytes, resulting in a wrong hash being computed.Since we recently started to always strictly validate package hashes, this is failing in
pixiand other downstream users.When I added some debug logging, it says:
bytes_read: 8192while the entire archive is
8198bytes long (so missing 6 bytes at the end).